-
-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite basic docs, without ExampleCrossPythonModule #4054
Comments
Would you mind taking a shot at this, @himanshumahajan138? |
@jodersky ya for sure i will add docs |
also should we make this inheritable(means we can inherit these docs later for other examples based on same pattern) or simple ?? |
I would suggest we keep it as simple as possible to start. Python support is a brand new feature, and while of course we want to implement a fully functional user experience, we also need to acknowledge that the first version will be no where near as polished as the scala and java support mill currently has. All to say, there will most likely be refactoring work to be done, and we can look into how we can extract common doc behavior when that time comes. Before is probably premature |
…[Basic Example] (com-lihaoyi#4063) # Pull Request Re-write Docs for First Class Python Support [Basic Example] Fixes: com-lihaoyi#4054 ## Description Rewrite Docs for Python `1-simple`, `2-custom-build-logic` and `3-multi-module` Examples ## Related Issues - Link to related issue com-lihaoyi#4054. ## Checklist - [x] Updated Documentation ## Status Updated & Require Review!!!
In light of the discussion here, #4042, we should re-write the example docs of
pythonlib/basic
, with a plain ExampleCrossModuleThe text was updated successfully, but these errors were encountered: