Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Edit this Page" links in docs are invalid #3858

Closed
lefou opened this issue Oct 28, 2024 · 1 comment · Fixed by #3861
Closed

"Edit this Page" links in docs are invalid #3858

lefou opened this issue Oct 28, 2024 · 1 comment · Fixed by #3861

Comments

@lefou
Copy link
Member

lefou commented Oct 28, 2024

"Edit this page" (in the page https://mill-build.org/mill/0.12.1/index.html) links to invalid
it should be here

Originally posted by @hojongs in #2590 (comment)
@lefou lefou changed the title It's invalid again"Edit this Page" links in docs are invalid "Edit this Page" links in docs are invalid Oct 28, 2024
@lefou
Copy link
Member Author

lefou commented Oct 28, 2024 •
edited
Loading

Actually, the edit link for the latest version, which points to the main branch, is correct. But all other versions are build from tags, so an edit ling doesn't make much sense. So, disabling the edit link for those tags makes more sense.

lefou added a commit to lefou/mill that referenced this issue Oct 28, 2024
@lefou
Docs: disable edit links for previous versions
96086aa 
All currently configured previous versions point to git tags, not branches. Hence editing on Github isn't fruitful.

Fix com-lihaoyi#3858
@lefou lefou mentioned this issue Oct 28, 2024
Merged
@lefou lefou closed this as completed in b449aae Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Docs: disable edit links for previous versions lefou/mill
1 participant
@lefou