Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package.mill support should require explicitly enablement #3409

Closed
lefou opened this issue Aug 22, 2024 · 1 comment · Fixed by #3573
Closed

package.mill support should require explicitly enablement #3409

lefou opened this issue Aug 22, 2024 · 1 comment · Fixed by #3573
Milestone

Comments

@lefou
Copy link
Member

lefou commented Aug 22, 2024

Currently, Mill is always scanning for module.sc files. We already discussed and agreed on the enablement of sub-modules through module.sc files via an $-import in PR #3213.

What could be a good name for the import? One of the candidates was submodules:

import $submodules._
@lihaoyi
Copy link
Member

lihaoyi commented Aug 23, 2024

import $submodules._ works for me. Eventually we may have some other way of passing flags, but for now this will do

@lefou lefou added this to the 0.12.0 milestone Aug 23, 2024
@lihaoyi lihaoyi changed the title module.sc support should require explicitly enablement package.mill support should require explicitly enablement Sep 4, 2024
lihaoyi added a commit that referenced this issue Sep 18, 2024
)

Fixes #3409 and also fixes
#3083

Updated `ci/mill-bootstrap.patch` and added a reference to the docs
@lefou lefou modified the milestones: 0.12.0-RC1, 0.12.0 Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants