Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JavaCompileJarTests rely on localized message #305

Closed
ggrossetie opened this issue Apr 30, 2018 · 0 comments
Closed

JavaCompileJarTests rely on localized message #305

ggrossetie opened this issue Apr 30, 2018 · 0 comments
Labels
solved The issue was fixed/resolved
Milestone
0.2.1

Comments

@ggrossetie
Copy link
Contributor

The following line is using a localized message:
https://github.com/lihaoyi/mill/blob/d86494099d7fca87ab1a8bf0b02ae305ad210d3b/main/test/src/mill/eval/JavaCompileJarTests.scala#L134

With a French locale, the exception message is: "impossible de trouver ou charger la classe principale".
In other words, if you are running the tests suite with a non English locale, the build will fail.

I think we should add the "-Duser.language=en" argument to the java command.
ggrossetie added a commit to ggrossetie/mill that referenced this issue Apr 30, 2018
@ggrossetie
Resolves com-lihaoyi#305, use an English locale when excuting java co…
15553c0 
…mmand line

Otherwise we cannot rely on the exception message because the error returned by the java command line will be localized.
@lefou lefou added this to the 0.2.1 milestone May 2, 2019
@lefou lefou added the solved The issue was fixed/resolved label Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
solved The issue was fixed/resolved
Projects
None yet
Milestone
0.2.1
Development

No branches or pull requests
2 participants
@ggrossetie @lefou