Handle optional value using null as default param

better than using empty string as default param.
com-lihaoyi · May 23, 2018 · ec362d8 · ec362d8
1 parent 63e49f9
commit ec362d8
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/scalalib/src/mill/scalalib/PublishModule.scala b/scalalib/src/mill/scalalib/PublishModule.scala
@@ -73,15 +73,15 @@ trait PublishModule extends JavaModule { outer =>
   }
 
   def publish(sonatypeCreds: String,
-              gpgPassphrase: String = "",
+              gpgPassphrase: String = null,
               signed: Boolean = true,
               release: Boolean): define.Command[Unit] = T.command {
     val PublishModule.PublishData(artifactInfo, artifacts) = publishArtifacts()
     new SonatypePublisher(
       sonatypeUri,
       sonatypeSnapshotUri,
       sonatypeCreds,
-      Some(gpgPassphrase).filter(_.nonEmpty),
+      Option(gpgPassphrase),
       signed,
       T.ctx().log
     ).publish(artifacts.map{case (a, b) => (a.path, b)}, artifactInfo, release)
@@ -96,7 +96,7 @@ object PublishModule extends ExternalModule {
   }
 
   def publishAll(sonatypeCreds: String,
-                 gpgPassphrase: String = "",
+                 gpgPassphrase: String = null,
                  signed: Boolean = true,
                  publishArtifacts: mill.main.Tasks[PublishModule.PublishData],
                  release: Boolean = false,
@@ -110,7 +110,7 @@ object PublishModule extends ExternalModule {
       sonatypeUri,
       sonatypeSnapshotUri,
       sonatypeCreds,
-      Some(gpgPassphrase).filter(_.nonEmpty),
+      Option(gpgPassphrase),
       signed,
       T.ctx().log
     ).publishAll(