Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Allow test classes with constructor parameters (#982)
This PR removes a filter from the test discovery that ignores classes that have parameters in their constructor. I think this is problematic as it is perfectly valid for tests to have constructor parameters depending on the test framework, and so this should be a decision made by the testing framework rather than the build tool. Here's an example where I encountered this issue recently: disneystreaming/weaver-test#113. After running these tests again with the changes made in this PR the example tests shown in that issue now pass. I've attempted to verify that these changes are compatible with other test frameworks. With some fairly basic examples uTest and Scalatest both seem to continue to work as expected. I'd be happy to verify the changes against other test frameworks if you have any further suggestions. Commits: * Add VS Code to gitignore * Remove constraint for parameter count Pull request: #982
- Loading branch information