Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@lihaoyi I have gone with Scala 3.5.0 here since that was the version I have been porting Mill to.
I didn't see any testing procedure - so I used the Mill integration tests to validate the override and scaladoc annotation inference is working. (Also I could remove all the override modifiers I had introduced in my Mill PR)
Note that now I made
moduledefs
a cross module in order to set the right "species" of scala versions to build plugin against. This is probably solved better with Cross2 but that needs to upgrade mill to 0.11.x which breaks the build in other ways I didn't want to touch