Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scala 3 port #14

Merged
merged 2 commits into from
Aug 21, 2024
Merged

Scala 3 port #14

merged 2 commits into from
Aug 21, 2024

Conversation

bishabosha
Copy link
Contributor

@bishabosha bishabosha commented Aug 21, 2024

@lihaoyi I have gone with Scala 3.5.0 here since that was the version I have been porting Mill to.

I didn't see any testing procedure - so I used the Mill integration tests to validate the override and scaladoc annotation inference is working. (Also I could remove all the override modifiers I had introduced in my Mill PR)

Note that now I made moduledefs a cross module in order to set the right "species" of scala versions to build plugin against. This is probably solved better with Cross2 but that needs to upgrade mill to 0.11.x which breaks the build in other ways I didn't want to touch

./millw -i resolve 'moduledefs'._
[1/1] resolve
moduledefs[2.13.14]
moduledefs[3.5.0]
./millw -i resolve 'moduledefs[2.13.14]'.plugin._
[1/1] resolve
moduledefs[2.13.14].plugin[2.13.0]
moduledefs[2.13.14].plugin[2.13.10]
moduledefs[2.13.14].plugin[2.13.11]
moduledefs[2.13.14].plugin[2.13.12]
moduledefs[2.13.14].plugin[2.13.13]
moduledefs[2.13.14].plugin[2.13.14]
moduledefs[2.13.14].plugin[2.13.1]
moduledefs[2.13.14].plugin[2.13.2]
moduledefs[2.13.14].plugin[2.13.3]
moduledefs[2.13.14].plugin[2.13.4]
moduledefs[2.13.14].plugin[2.13.5]
moduledefs[2.13.14].plugin[2.13.6]
moduledefs[2.13.14].plugin[2.13.7]
moduledefs[2.13.14].plugin[2.13.8]
moduledefs[2.13.14].plugin[2.13.9]
./millw -i resolve 'moduledefs[3.5.0]'.plugin._
[1/1] resolve
moduledefs[3.5.0].plugin[3.5.0]

@lihaoyi
Copy link
Member

lihaoyi commented Aug 21, 2024

Sounds good. We do not have standalone tests for this repo AFAIK, so testing indirectly through Mill will have to do. I can tag a release once we merge this

cc @lefou

@bishabosha bishabosha force-pushed the scala3-port branch 2 times, most recently from d42ce8f to 6450447 Compare August 21, 2024 08:15
@lefou
Copy link
Member

lefou commented Aug 21, 2024

We don't have separate tests. This project makes only sense for Mill and is tested as part of Mills test suites. We just have it standalone to have a Mill-independent lifecycle and be able to publish (older) versions for new Scala compiler versions.

@lihaoyi lihaoyi merged commit 0c58829 into com-lihaoyi:main Aug 21, 2024
8 checks passed
@lihaoyi
Copy link
Member

lihaoyi commented Aug 22, 2024

@bishabosha I tagged this as 0.11.0-M1, should go out in the next few hours

@lefou lefou added this to the after 0.10.9 milestone Aug 22, 2024
@bishabosha
Copy link
Contributor Author

@lihaoyi there was some issue in the sonatype publishing task

@lihaoyi
Copy link
Member

lihaoyi commented Aug 22, 2024

On it. Hopefully ea6c82c should fix

@lihaoyi
Copy link
Member

lihaoyi commented Aug 22, 2024

@bishabosha bishabosha deleted the scala3-port branch August 22, 2024 06:24
@bishabosha
Copy link
Contributor Author

Yep its working, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants