fix css comment bug. #256
Merged
fix css comment bug. #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lihaoyi Could I get a review at your convenience? This is pretty non-invasive 😄 |
|
@DanHodges Can you rebase on top of master and, instead of modifying an existing test, create a new test with a name pointing at the issue (like issue-#255 or something along those lines) with a minimal reproduction of the issue? |
… the comment is the last line in a block.
No problem - thanks for taking a look 😄 |
lolgab
approved these changes
Sep 6, 2021
|
Released fastparse |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #255
Enable backtracking on comments, otherwise the parser will error when the comment is last line in a block.