Use ctx.bytes rather than getting the InputStream directly #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e contents of the InputStream are cached in the Request object
|
@lihaoyi can you please review this? It's been open for awhile and is a very small change. |
|
Superseded by #123 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use ctx.bytes rather than getting the InputStream directly so that the contents of the InputStream are cached in the Request object. Right now if a Decorator tries to access the request body via the InputStream the InputStream will then be empty for the postJson decorator. Therefore, postJson should use the bytes field of Request so if an upstream Decorator also accesses the bytes field the value will be cached.