Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It is not possible to handle unknown query parameters #99

Closed
OndrejSpanel opened this issue Dec 18, 2023 · 0 comments · Fixed by #108
Closed

It is not possible to handle unknown query parameters #99

OndrejSpanel opened this issue Dec 18, 2023 · 0 comments · Fixed by #108

Comments

@OndrejSpanel
Copy link
Contributor

OndrejSpanel commented Dec 18, 2023

Sometimes it would be handy to allow any unknown query parameters.

Motivation 1:

One of my endpoints is used for GitHub OAuth loopback. While the behavior in case of success is well documented as receiving code and state parameters, in case of error the documentation is lacking. While I have experimentally determined the parameters in such case to be error, error_description and error_uri, this is undocumented and perhaps could change anytime, causing my error handling not working as expected. Moreover. I am not really interested in some of them, but I cannot prevent them being included. At the moment I have to add them to the endpoint just to ignore them.

Motivation 2:

I am processing query parameters using request.queryParams in my endpoint, yet I have to list all possible parameter names in my endpoint signature. This contrast with subPath option available for paths. I can easily create an endpoint serving any subpath, but not any query parameters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant