Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update all sorts of stuff #82

Merged
merged 3 commits into from
Jul 12, 2022
Merged

Conversation

ckipp01
Copy link
Contributor

@ckipp01 ckipp01 commented Jul 4, 2022

This pr goes through and makes the various updates:

  • Bumps mill to the latest 0.10.5
  • Bumps to the latest Scala versions for 2 and latest 3.1.x version
  • Drops 0.x support for ScalaJS
  • Move Scala native to 0.4.x
  • Adds in dependabot
  • Starts to cross test on 8 and 17
  • Updates checkout and java actions

This pr goes through and makes the various updates:
  - Bumps mill to the latest 0.10.5
  - Bumps to the latest Scala versions for 2 and latest 3.1.x version
  - Drops 0.x support for ScalaJS
  - Move Scala native to 0.4.x
  - Adds in dependabot
  - Starts to cross test on 8 and 17
  - Updates checkout and java actions
@ckipp01
Copy link
Contributor Author

ckipp01 commented Jul 4, 2022

So there is still one thing I'm trying to figure out with this. The Mima tests pass for 2.13.6, but once I bump past that the 2.13 ScalaJS check fails with

Found 2 issue when checking against com.lihaoyi:pprint_sjs1_2.13:0.7.3
 * static method apply(scala.collection.Iterable)java.lang.String in class pprint.StringPrefix has a different generic signature in current version, where it is (Lscala/collection/Iterable<Ljava/lang/Object;>;)Ljava/lang/String; rather than (Lscala/collection/Iterable<*>;)Ljava/lang/String;. See https://github.com/lightbend/mima#incompatiblesignatureproblem
   filter with: ProblemFilter.exclude[IncompatibleSignatureProblem]("pprint.StringPrefix.apply")
 * method apply(scala.collection.Iterable)java.lang.String in object pprint.StringPrefix has a different generic signature in current version, where it is (Lscala/collection/Iterable<Ljava/lang/Object;>;)Ljava/lang/String; rather than (Lscala/collection/Iterable<*>;)Ljava/lang/String;. See https://github.com/lightbend/mima#incompatiblesignatureproblem
   filter with: ProblemFilter.exclude[IncompatibleSignatureProblem]("pprint.StringPrefix.apply")
1 targets failed
pprint.js[2.13.7,1.10.1].mimaReportBinaryIssues Failed binary compatibility check! Found 2 potential problems

So trying to figure this out.

EDIT: So I'm pretty sure this is a false positive. Looking at the README of mima they have [IncompatibleSignature[(https://github.com/lightbend/mima#incompatiblesignatureproblem) turned off by default with the message:

but also sometimes triggers for a change in generics that would not in fact cause problems at run time. Notably, it will warn when updating your project to scala 2.12.9+ or 2.13.1+, see lightbend-labs/mima#423 for details.

I believe we're hitting on that here so I just filtered that out for 2.13.

@lolgab
Copy link
Member

lolgab commented Jul 11, 2022

Thank you for this @ckipp01!
About the MiMa issue, I released a new version of mill-mima (0.0.11) which has the same behaviour as the Sbt plugin, so if you update you should be able to remove the configuration you added:

  // By default in sbt-mima IncompatibleSignatureProblem is actually turned off
  // by default due to false positives. We hit on this with 2.13 > 2.13.6 with
  // * static method apply(scala.collection.Iterable)java.lang.String in class pprint.StringPrefix has a different generic signature in current version, where it is (Lscala/collection/Iterable<Ljava/lang/Object;>;)Ljava/lang/String; rather than (Lscala/collection/Iterable<*>;)Ljava/lang/String;. See https://github.com/lightbend/mima#incompatiblesignatureproblem
  def mimaBinaryIssueFilters = if (crossScalaVersion.startsWith("2.13"))  {
    super.mimaBinaryIssueFilters() ++ Seq(
      ProblemFilter.exclude[IncompatibleSignatureProblem]("pprint.StringPrefix.apply")
    )
  } else {
    super.mimaBinaryIssueFilters()
  }

@lolgab
Copy link
Member

lolgab commented Jul 11, 2022

Also, I released fansi 0.4.0 with your updates.

@ckipp01
Copy link
Contributor Author

ckipp01 commented Jul 11, 2022

Also, I released fansi 0.4.0 with your updates.

Sounds good. I updated this and to the new mill-mima.

@lolgab
Copy link
Member

lolgab commented Jul 11, 2022

Sorry, forgot to mention sourcecode 0.3.0 which was released with your changes.

@ckipp01
Copy link
Contributor Author

ckipp01 commented Jul 11, 2022

Sorry, forgot to mention sourcecode 0.3.0 which was released with your changes.

Updated!

@lolgab lolgab self-requested a review July 12, 2022 08:50
@lolgab lolgab merged commit 2203dc6 into com-lihaoyi:master Jul 12, 2022
@ckipp01 ckipp01 deleted the updates branch July 12, 2022 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants