-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: update all sorts of stuff #82
Conversation
This pr goes through and makes the various updates: - Bumps mill to the latest 0.10.5 - Bumps to the latest Scala versions for 2 and latest 3.1.x version - Drops 0.x support for ScalaJS - Move Scala native to 0.4.x - Adds in dependabot - Starts to cross test on 8 and 17 - Updates checkout and java actions
So there is still one thing I'm trying to figure out with this. The Mima tests pass for 2.13.6, but once I bump past that the 2.13 ScalaJS check fails with
So trying to figure this out. EDIT: So I'm pretty sure this is a false positive. Looking at the README of mima they have [IncompatibleSignature[(https://github.com/lightbend/mima#incompatiblesignatureproblem) turned off by default with the message:
I believe we're hitting on that here so I just filtered that out for 2.13. |
Thank you for this @ckipp01! // By default in sbt-mima IncompatibleSignatureProblem is actually turned off
// by default due to false positives. We hit on this with 2.13 > 2.13.6 with
// * static method apply(scala.collection.Iterable)java.lang.String in class pprint.StringPrefix has a different generic signature in current version, where it is (Lscala/collection/Iterable<Ljava/lang/Object;>;)Ljava/lang/String; rather than (Lscala/collection/Iterable<*>;)Ljava/lang/String;. See https://github.com/lightbend/mima#incompatiblesignatureproblem
def mimaBinaryIssueFilters = if (crossScalaVersion.startsWith("2.13")) {
super.mimaBinaryIssueFilters() ++ Seq(
ProblemFilter.exclude[IncompatibleSignatureProblem]("pprint.StringPrefix.apply")
)
} else {
super.mimaBinaryIssueFilters()
} |
Also, I released fansi 0.4.0 with your updates. |
Sounds good. I updated this and to the new |
Sorry, forgot to mention |
Updated! |
This pr goes through and makes the various updates: