Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update readme about automated testing #1283

Merged

Conversation

tanishiking
Copy link
Contributor

The previous version of developer documents around
automated testings are written in 6-7 years ago
when the sbt was used for build tools.
ea5227c

This commit update the command for automated testing
for mill.

- `amm/test` tests the Ammonite-REPL/Script-runner, without filesystem-shell integration.
- `terminal/test` tests the readline re-implementation: keyboard navigation, shortcuts, editing, without any filesystem/scala-repl logic
- `shell/test` tests the integration between the standalone `ops/` and `amm/` projects: features like `cd!`/`wd`, path-completion, ops-related pretty-printing and tools
- `integration/test` kicks off the integration tests, which bundle `amm/` and `shell/` into their respective jars and invoke them as subprocesses. Somewhat slow, but exercises all the command-line-parsing stuff that the other unit tests do not exercise, and makes sure that everything works when run from `.jar`s instead of loose class-files
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed integration/test, ops/test, and shell/test as it looks like they're already obsoleted.

Copy link
Collaborator

@alexarchambault alexarchambault Aug 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not all of them I think. One can call

$ ./mill -i 'integration[2.13.8].test'
$ ./mill -i 'sshd[2.13.8].test'

Copy link
Collaborator

@alexarchambault alexarchambault Aug 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But ops went away, yes (in #1227).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, thanks! Added for integration and sshd

The previous version of developer documents around
automated testings are written in 6-7 years ago
when the sbt was used for build tools.
com-lihaoyi@ea5227c

This commit update the command for automated testing
for mill.
@tanishiking tanishiking force-pushed the update-readme-devdocs branch from d7255ff to bec02ae Compare August 24, 2022 05:09
Copy link
Collaborator

@alexarchambault alexarchambault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@alexarchambault alexarchambault merged commit 7317286 into com-lihaoyi:master Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants