Swap over script @main and Ammonite main argument parsing over to https://github.com/lihaoyi/mainargs #1126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lihaoyi
added a commit
to com-lihaoyi/mill
that referenced
this pull request
Nov 24, 2020
…inargs (#1008) This replaces the copy-paste logic handling both Mill's own CLI argument parsing as well as the CLI argument parsing of user-defined `T.command`s to instead rely on the https://github.com/lihaoyi/mainargs implementation. This is similar to the earlier PR that performed such a migration in the lihaoyi/Ammonite repo com-lihaoyi/Ammonite#1126 Where the semantics of Mill's own CLI parsing and `T.command` CLI parsing differ, we pass in the corresponding flags to handle the difference, e.g. `allowPositional = false` for Mill's own parameters and `allowPositional = false` for `T.command`s. Since the MainArgs library is standalone, we also cut the dependency on Scopt since it is now unnecessary. Our existing `scopt.Reads` are all replaced by `mainargs.TokensReader` Things compile, haven't tested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings with it slight incompatibilities that arise from the cleaned up API, but lets us delete large swathes of boilerplate code that are copy-pasted between this and other repositories I maintain