Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Implement support for "Hellwig and Fairchild (2022) Colour Appearance Model". #972

Merged
merged 1 commit into from
May 4, 2022
Merged

PR: Implement support for "Hellwig and Fairchild (2022) Colour Appearance Model". #972

merged 1 commit into from
May 4, 2022

Conversation

KelSolaar
Copy link
Member

@KelSolaar KelSolaar commented May 2, 2022 •
edited
Loading

Summary

This PR implements support for Hellwig and Fairchild (2022) Colour Appearance Model.

References

Preflight

Code Style and Quality

  • Unit tests have been implemented and passed.
  • Mypy static checking has been run and passed.
  • Pre-commit hooks have been run and passed.
  • New transformations have been added to the Automatic Colour Conversion Graph.
  • New transformations have been exported to the relevant namespaces, e.g. colour, colour.models.

Documentation

  • New features are documented along with examples if relevant.
  • The documentation is Sphinx and numpydoc compliant.

@KelSolaar KelSolaar requested a review from a team May 2, 2022 09:59
@KelSolaar KelSolaar added this to the v0.4.2 milestone May 2, 2022
@coveralls
Copy link

coveralls commented May 2, 2022 •
edited
Loading

Coverage Status

Coverage increased (+0.001%) to 99.828% when pulling 9ca8486 on feature/hellwig2022 into bbaea60 on develop.

@KelSolaar KelSolaar force-pushed the feature/hellwig2022 branch from 14f6b46 to 9ca8486 Compare May 3, 2022 06:28
@KelSolaar KelSolaar merged commit 1b6d4ea into develop May 4, 2022
@KelSolaar KelSolaar deleted the feature/hellwig2022 branch May 29, 2022 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.4.2
Development

Successfully merging this pull request may close these issues.
2 participants
@KelSolaar @coveralls