Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Implement support for Python 3.12. #1224

Merged
merged 11 commits into from
Nov 19, 2023
Merged

PR: Implement support for Python 3.12. #1224

merged 11 commits into from
Nov 19, 2023

Conversation

KelSolaar
Copy link
Member

Summary

This PR implements support for Python 3.12. A few new pre-commit hooks were also added according to https://learn.scientific-python.org/development/guides/repo-review/?repo=colour-science%2Fcolour&branch=develop.

I was not able to install PyGraphviz on macOS Sonoma so it was excluded in the pyproject.toml file. So is OpenColorIO which has no 3.12 wheels yet.

Preflight

Code Style and Quality

  • Unit tests have been implemented and passed.
  • Pyright static checking has been run and passed.
  • Pre-commit hooks have been run and passed.
  • [N/A] New transformations have been added to the Automatic Colour Conversion Graph.
  • [N/A] New transformations have been exported to the relevant namespaces, e.g. colour, colour.models.

Documentation

  • [N/A] New features are documented along with examples if relevant.
  • [N/A] The documentation is Sphinx and numpydoc compliant.

@KelSolaar KelSolaar added this to the v0.4.4 milestone Nov 19, 2023
@coveralls
Copy link

coveralls commented Nov 19, 2023

Coverage Status

coverage: 99.733%. remained the same
when pulling 79afdd0 on feature/python-3.12
into c816594 on develop.

@KelSolaar KelSolaar merged commit c9574ad into develop Nov 19, 2023
32 checks passed
@KelSolaar KelSolaar deleted the feature/python-3.12 branch December 17, 2023 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants