Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Implement support for "PLASA ANSI E1.54" colourspace. #1193

Merged
merged 2 commits into from
Aug 19, 2023

Conversation

KelSolaar
Copy link
Member

Summary

This PR implements support for "PLASA ANSI E1.54" colourspace. Note that I found a discrepancy between the whitepoint chromaticity coordinates and its derivation/design:

https://www.mikewoodconsulting.com/articles/Protocol%20Fall%202014%20-%20Color%20Communication.pdf states "Accordingly, the white point is defined as follows as a 2° Planckian source at 3,200 K": x=0.4254, y=0.4044

We compute different chromaticity coordinates:

>>> sd = colour.sd_blackbody(3200)
>>> colour.XYZ_to_xy(
...     colour.sd_to_XYZ(
...         sd, colour.MSDS_CMFS["CIE 1931 2 Degree Standard Observer"]
...     )
... ).round(4)
array([ 0.4234,  0.399 ])

Preflight

Code Style and Quality

  • Unit tests have been implemented and passed.
  • Pyright static checking has been run and passed.
  • Pre-commit hooks have been run and passed.
  • New transformations have been added to the Automatic Colour Conversion Graph.
  • New transformations have been exported to the relevant namespaces, e.g. colour, colour.models.

Documentation

  • New features are documented along with examples if relevant.
  • The documentation is Sphinx and numpydoc compliant.

@KelSolaar KelSolaar added this to the v0.4.3 milestone Aug 12, 2023
@KelSolaar KelSolaar requested a review from tjdcs August 12, 2023 22:31
@coveralls
Copy link

coveralls commented Aug 12, 2023

Coverage Status

coverage: 99.775%. remained the same when pulling c175b2e on feature/plasa_ansi_e154 into 2263e01 on develop.

@KelSolaar
Copy link
Member Author

Merging this one, I will send an email to Mike Wood for the chromaticity coordinates.

@KelSolaar KelSolaar merged commit 8c090f9 into develop Aug 19, 2023
@KelSolaar KelSolaar deleted the feature/plasa_ansi_e154 branch August 19, 2023 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants