Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Remove ability to pass illuminant in "CIE XYZ" to "CIE xyY" related transformations. #1153

Merged
merged 1 commit into from
May 26, 2023

Conversation

KelSolaar
Copy link
Member

@KelSolaar KelSolaar commented May 19, 2023

Summary

This one has been itching me for a while, it is a very old behaviour that is very strongly opinionated but not recommended by CIE during the computation of chromaticity coordinates: When the tristimulus values are null, we do set the chromaticity coordinates to the passed illuminant ones and the luminance to zero. This is what Bruce Lindbloom is doing. It is quite useful as it means that the achromatic colours are all on the same axis but I reckon that this is a behaviour that should be controlled by the user post-conversion. We do not do that with any other space for that matter.

image

Preflight

Code Style and Quality

  • Unit tests have been implemented and passed.
  • Pyright static checking has been run and passed.
  • Pre-commit hooks have been run and passed.
  • [N/A] New transformations have been added to the Automatic Colour Conversion Graph.
  • [N/A] New transformations have been exported to the relevant namespaces, e.g. colour, colour.models.

Documentation

  • [N/A] New features are documented along with examples if relevant.
  • The documentation is Sphinx and numpydoc compliant.

…ransformations.

This is not a CIE recommendation and the choice of what to when null tristimulus values are passed should be given to the user.
@KelSolaar KelSolaar added this to the v0.4.3 milestone May 19, 2023
@KelSolaar KelSolaar requested a review from tjdcs May 19, 2023 06:50
@coveralls
Copy link

Coverage Status

Coverage: 99.786% (-5.0e-05%) from 99.786% when pulling ef449fd on feature/cie_xyy into 93deeab on develop.

@KelSolaar KelSolaar merged commit bfecf90 into develop May 26, 2023
@KelSolaar
Copy link
Member Author

Merging this one, as it improves consistency across the board, especially with regard to the few other space that do projective transformations.

@KelSolaar KelSolaar deleted the feature/cie_xyy branch July 21, 2023 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants