Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Implement support for "ARRI Wide Gamut 4" and "ARRI LogC4". #1056

Merged
merged 3 commits into from
Nov 7, 2022

Conversation

KelSolaar
Copy link
Member

@KelSolaar KelSolaar commented Oct 24, 2022

Summary

This PR implements support for ARRI Wide Gamut 4 and ARRI LogC4.

The existing ALEXA Wide Gamut colourspace and ALEXA LogC log encoding have been renamed to ARRI Wide Gamut 3 and ARRI LogC3 respectively.

@JGoldstone for VIS.

Preflight

Code Style and Quality

  • Unit tests have been implemented and passed.
  • Mypy static checking has been run and passed.
  • Pre-commit hooks have been run and passed.
  • [N/A] New transformations have been added to the Automatic Colour Conversion Graph.
  • New transformations have been exported to the relevant namespaces, e.g. colour, colour.models.

Documentation

  • New features are documented along with examples if relevant.
  • The documentation is Sphinx and numpydoc compliant.

…decoding_ALEXALogC" definitions to "log_encoding_ARRILogC3" and "log_decoding_ARRILogC3" respectively.
@KelSolaar KelSolaar marked this pull request as draft October 24, 2022 08:21
@coveralls
Copy link

Coverage Status

Coverage increased (+0.0005%) to 99.808% when pulling 5a97084 on feature/arri_logc_4 into 065c3a6 on develop.

@KelSolaar KelSolaar marked this pull request as ready for review October 25, 2022 07:27
@KelSolaar
Copy link
Member Author

@nick-shaw, @scoopxyz : Be glad if you could drop a quick eye on this one, keen to merge it to get going on 0.4.2 release.

Cheers,

Thomas

@KelSolaar
Copy link
Member Author

Been two weeks, I will merge this one!

@KelSolaar KelSolaar merged commit d0152dc into develop Nov 7, 2022
@KelSolaar KelSolaar deleted the feature/arri_logc_4 branch November 7, 2022 08:56
@KelSolaar KelSolaar added this to the v0.4.2 milestone Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants