Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Ensure that conversion from spectral to XYZ returns non-percentage values when "k" is not "None". #1020

Merged
merged 1 commit into from
Jul 31, 2022

Conversation

KelSolaar
Copy link
Member

Summary

This PR ensures that conversion from spectral to XYZ returns non-percentage values when k is not None.

References #1018.

Preflight

Code Style and Quality

  • Unit tests have been implemented and passed.
  • Mypy static checking has been run and passed.
  • Pre-commit hooks have been run and passed.
  • [N/A] New transformations have been added to the Automatic Colour Conversion Graph.
  • [N/A] New transformations have been exported to the relevant namespaces, e.g. colour, colour.models.

Documentation

  • [N/A] New features are documented along with examples if relevant.
  • [N/A] The documentation is Sphinx and numpydoc compliant.

@KelSolaar KelSolaar added this to the v0.4.2 milestone Jul 31, 2022
@coveralls
Copy link

Coverage Status

Coverage increased (+3.0e-05%) to 99.836% when pulling 5f706c9 on feature/k_absolute into 4ce59f3 on develop.

@KelSolaar KelSolaar merged commit fedf06f into develop Jul 31, 2022
@KelSolaar KelSolaar deleted the feature/k_absolute branch July 31, 2022 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants