-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: improve member directory filter #570
base: main
Are you sure you want to change the base?
refactor: improve member directory filter #570
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @arelymartinez16! I was testing it locally and I really like how the new buttons look. The functionality is mostly work well, except that it seems when we have a Company tag and then try to add a school tag, the company tag gets replaced, when instead we would want the School tag AND the company tag to be present. Let me know if you need any help with this fix!
Also, it seems that the CI test is failing because of formatting issues. Make sure that you have the Prettier extension set up properly-take a look at the Contributing guide for more details!
Hi @tomas-salgado, I met with my mentor yesterday and he thought the issue was that there was one company under the "companies" table which was a company I listed in the work experience of my member profile. Either way, I don't know where to look to fix this issue :( |
I'm so confused why the company tag faces that issue but the school tags works well. I also noticed when I filter a company that is not in my work's experience the tag is not there at all. I have tried using the loader function on the FilterDirectoryDropdown component to ensure the company filter is included in the search params alongside the other filters but it still doesn't work. |
I am going to check out the offers page to see how the filters were implemented. |
Forgot to mention I fixed the issue a few weeks ago. |
Description ✏️
Closes #539
Describe what this PR does.
Type of Change 🐞
Checklist ✅