Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: improve member directory filter #570

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

arelymartinez16
Copy link
Contributor

Description ✏️

Closes #539

Describe what this PR does.

  • Create two filter dropdowns for 'Company' and 'School'.
  • Clicking on a filter option automatically updates the displayed results in real-time, based on the selected criteria.

Type of Change 🐞

  • Feature - A non-breaking change which adds functionality.
  • Fix - A non-breaking change which fixes an issue.
  • Refactor - A change that neither fixes a bug nor adds a feature.
  • Documentation - A change only to in-code or markdown documentation.
  • Tests - A change that adds missing unit/integration tests.
  • Chore - A change that is likely none of the above.

Checklist ✅

  • I have done a self-review of my code.
  • I have manually tested my code (if applicable).
  • I have added/updated any relevant documentation (if applicable).

Copy link
Collaborator

@tomas-salgado tomas-salgado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @arelymartinez16! I was testing it locally and I really like how the new buttons look. The functionality is mostly work well, except that it seems when we have a Company tag and then try to add a school tag, the company tag gets replaced, when instead we would want the School tag AND the company tag to be present. Let me know if you need any help with this fix!

Also, it seems that the CI test is failing because of formatting issues. Make sure that you have the Prettier extension set up properly-take a look at the Contributing guide for more details!

apps/member-profile/app/routes/_profile.directory.tsx Outdated Show resolved Hide resolved
apps/member-profile/app/routes/_profile.directory.tsx Outdated Show resolved Hide resolved
apps/member-profile/app/routes/_profile.directory.tsx Outdated Show resolved Hide resolved
@tomas-salgado tomas-salgado added the Bloomberg This issue is reserved for the Bloomberg Mentorship Program label Oct 27, 2024
@arelymartinez16
Copy link
Contributor Author

Hi @tomas-salgado, I met with my mentor yesterday and he thought the issue was that there was one company under the "companies" table which was a company I listed in the work experience of my member profile. Either way, I don't know where to look to fix this issue :(

@arelymartinez16
Copy link
Contributor Author

I'm so confused why the company tag faces that issue but the school tags works well. I also noticed when I filter a company that is not in my work's experience the tag is not there at all.

I have tried using the loader function on the FilterDirectoryDropdown component to ensure the company filter is included in the search params alongside the other filters but it still doesn't work.

@arelymartinez16
Copy link
Contributor Author

I am going to check out the offers page to see how the filters were implemented.

@arelymartinez16
Copy link
Contributor Author

Forgot to mention I fixed the issue a few weeks ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bloomberg This issue is reserved for the Bloomberg Mentorship Program
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Member Directory Filter 👥
3 participants