Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: keyboard support for Dropdown ComboBox #550

Closed
wants to merge 30 commits into from

Conversation

wflore19
Copy link
Contributor

@wflore19 wflore19 commented Oct 4, 2024

Description ✏️

Closes #271
related to PR #329

  • Adds keyboard support for Dropdown combobox

popover-keyboard-support
(The background color on hover does not appear in my recording software but here's what it looks like)
image

  • Changes functionality of <MultiComboBox />
  • Updates all <MultiComboBox /> implementations

Type of Change 🐞

  • Feature - A non-breaking change which adds functionality.
  • Fix - A non-breaking change which fixes an issue.
  • Refactor - A change that neither fixes a bug nor adds a feature.
  • Documentation - A change only to in-code or markdown documentation.
  • Tests - A change that adds missing unit/integration tests.
  • Chore - A change that is likely none of the above.

Checklist ✅

  • I have done a self-review of my code.
  • I have manually tested my code (if applicable).
  • I have added/updated any relevant documentation (if applicable).

@wflore19
Copy link
Contributor Author

wflore19 commented Oct 7, 2024

I'm going to double check and work on this with my Bloomberg mentor 📝

@wflore19
Copy link
Contributor Author

@ramiAbdou ramiAbdou closed this Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keyboard interactions not working on dropdown combobox ⌨️
2 participants