Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: schedule pre-event notifications job 📆 #506

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

rafa1510
Copy link
Contributor

@rafa1510 rafa1510 commented Sep 10, 2024

Description ✏️

Closes #478

Describe what this PR does.

Type of Change 🐞

  • Feature - A non-breaking change which adds functionality.
  • Fix - A non-breaking change which fixes an issue.
  • Refactor - A change that neither fixes a bug nor adds a feature.
  • Documentation - A change only to in-code or markdown documentation.
  • Tests - A change that adds missing unit/integration tests.
  • Chore - A change that is likely none of the above.

Checklist ✅

  • I have done a self-review of my code.
  • I have manually tested my code (if applicable).
  • I have added/updated any relevant documentation (if applicable).

@rafa1510 rafa1510 changed the title Schedule Pre-event notifications job feat: schedule pre-event notifications job Sep 16, 2024
Copy link
Collaborator

@tomas-salgado tomas-salgado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @rafa1510! A lot of the logic for creating the job looks solid, but at a higher level it seems that in this PR we are creating a new worker preEventNotificationWorker to run the job, but we should be able to just add the new job to the existing eventWorker. Let me know if you have any questions on doing this!

@rafa1510
Copy link
Contributor Author

rafa1510 commented Oct 9, 2024

Done 🫡

Copy link
Collaborator

@tomas-salgado tomas-salgado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really great @rafa1510! Going to mark it for Rami to take a final review. Great work! 🚀

Note for @ramiAbdou: Rafa commented on this but we just have to make sure to merge #524 first

@tomas-salgado tomas-salgado changed the title feat: schedule pre-event notifications job feat: schedule pre-event notifications job 📆 Dec 12, 2024
@tomas-salgado tomas-salgado added the Ready ✅ This PR is ready for a final review. label Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready ✅ This PR is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Schedule Pre-event notifications job 📆
2 participants