-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: schedule pre-event notifications job 📆 #506
base: main
Are you sure you want to change the base?
feat: schedule pre-event notifications job 📆 #506
Conversation
this job will execute sendPreEventNotification() 2 days before an event
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @rafa1510! A lot of the logic for creating the job looks solid, but at a higher level it seems that in this PR we are creating a new worker preEventNotificationWorker
to run the job, but we should be able to just add the new job to the existing eventWorker. Let me know if you have any questions on doing this!
Done 🫡 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really great @rafa1510! Going to mark it for Rami to take a final review. Great work! 🚀
Note for @ramiAbdou: Rafa commented on this but we just have to make sure to merge #524 first
Description ✏️
Closes #478
Describe what this PR does.
sendPreEventNotification
needs to be updated when Infrastructure for Pre-event notifications 🔔 #477 is merged. For now there's aconsole.log
statement used for debugging purposes.Type of Change 🐞
Checklist ✅