-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: infrastructure for school chapters 📖 #500
base: main
Are you sure you want to change the base?
Conversation
846a910
to
15a613a
Compare
Tried to leave this more open for extension, since this is only a small start for chapters. Therefore, I mimicked more of how the school creation works with some core files in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested this locally and it's working great! Left a few minor comments-almost ready to go
apps/admin-dashboard/app/routes/_dashboard.schools.chapters.$id.create.tsx
Outdated
Show resolved
Hide resolved
apps/admin-dashboard/app/routes/_dashboard.schools.chapters.$id.create.tsx
Outdated
Show resolved
Hide resolved
bc9e08d
to
795dfeb
Compare
@tomas-salgado should be all set now :) Thanks for the review! Ended up giving it a rebase to fixup my commit with your comments |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @iperalta7! LGTM 🚀
Description ✏️
Closes #498
A chapters table is created, so that admins can mark a school that has a chapter.
Should store schools that have chapters by linking school_id and storing timestamp when school was added to
chapters
tableNew dropdown with a confirmation modal to add a school to chapters table (should not be shown for schools already in table)
Add new dropdown field to school to add as a chapter in admin dashboard
New data table for chapters
chapter-infra-pr.-.Made.with.Clipchamp.mp4
Type of Change 🐞
Checklist ✅