[6.0] feat: remove MAINTAIN_SESSION_POOL from SessionNotFoundErrorMode #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taka-oyama
requested review from
dkkoma,
zeriyoshi,
halnique and
t-matsuno-777
taka-oyama
commented
Aug 17, 2023
| @@ -282,30 +282,14 @@ By default, laravel-spanner uses [Filesystem Cache Adapter](https://symfony.com/ | |||
| There are a few cases when a 'Session not found' error can | |||
| [happen](https://cloud.google.com/spanner/docs/sessions#handle_deleted_sessions): | |||
|
|
|||
| - Scripts that idle too long - for example, a [Laravel queue worker](https://laravel.com/docs/9.x/queues#the-queue-work-command) | |||
| or anything that doesn't call Spanner frequently enough (more than once an hour). | |||
| - The session is more than 28 days old. | |||
There was a problem hiding this comment.
Removed since this is no longer true.
taka-oyama
changed the title
taka-oyama
force-pushed
the
feature/remove-maintain-mode
branch
from
959c55b to
14ee9d7
Compare
taka-oyama
force-pushed
the
feature/remove-maintain-mode
branch
from
49f4f36 to
21d9fef
Compare
t-matsuno-777
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is no longer needed since we now know running maintain doesn't remove any stale sessions that are "inUse".
googleapis/google-cloud-php#6284 (comment)