Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prev camp button #10

Closed
wants to merge 2 commits into from
Closed

Prev camp button #10

wants to merge 2 commits into from

Conversation

chozabu
Copy link
Contributor

@chozabu chozabu commented Jun 2, 2015

Hey - this probably needs some tweaks before merging - but I thought I'd issue a PR anyway!

@chozabu chozabu mentioned this pull request Jun 3, 2015
6 tasks
@wvengen
Copy link
Member

wvengen commented Jun 5, 2015

I like the initial view, well done! Some things we could improve:

  • Act on mouseover/mouseout instead of requiring to click
  • Make background white instead of transparent (zoom in and you'll see why)
  • Is it responsive/mobile-friendly?
  • I think it would be nice to have a visual element surrounding the camps, in addition to any dotted border indicating selection when the camp list is shown. Perhaps a sliding drawer?
  • Auto-generate list of events

@chozabu
Copy link
Contributor Author

chozabu commented Jun 5, 2015

Thanks for the feedback!
As for "Act on mouseover/mouseout instead of requiring to click" - I'd gone for click rather than mouseover thinking it would be better for mobile, but perhaps that is not needed, and touching on mobile is also handled as hovering?

I'm not at my dev machine for a few mins, but will have a zoomed in look soon!

Unsure how mobile friendly/responsive it is - will also check that out when at dev machine.

Not 100% sure on what you mean about visual changes - though I am aware quite a bit could be done to make it look nicer.

Auto-generating page lists would be great! I had a quick look into it - sounds like jekyll collections would be the right way to go. I'll see what I can work out here too.

I am, as usual, happy for anyone to replace any code I do with something better ;)

@chozabu chozabu closed this Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants