Fix Record#setAudioOutput for non Audio only players

collab-project · Sep 27, 2024 · 0dfa5f9 · 0dfa5f9
1 parent 1285cec
commit 0dfa5f9
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 1 deletion.
diff --git a/src/js/videojs.record.js b/src/js/videojs.record.js
@@ -1897,7 +1897,7 @@ class Record extends Plugin {
                 break;
 
             default:
-                let element = player.tech_.el_;
+                let element = this.player.tech_.el_;
                 if (deviceId) {
                     if (typeof element.sinkId !== 'undefined') {
                         element.setSinkId(deviceId).then((result) => {

diff --git a/test/videojs.record.spec.js b/test/videojs.record.spec.js
@@ -481,6 +481,27 @@ describe('Record', () => {
         });
     });
 
+    /** @test {Record#setAudioOutput} */
+    it('can set audio output for video player', (done) => {
+        // create new audio-video player
+        let player = TestHelpers.makeAudioVideoPlayer();
+
+        player.one(Event.ERROR, (e) => {
+            expect(e.type).toEqual(Event.ERROR);
+
+            done();
+        });
+
+        player.one(Event.ENUMERATE_READY, () => {
+            player.record().setAudioOutput('fakeId');
+        });
+
+        player.one(Event.READY, () => {
+            player.record().enumerateDevices();
+        });
+    });
+
+
     /** @test {Record#saveAs} */
     it('saves as', (done) => {
         // create new player