Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Enable building with Noir compiler >=0.19.0 #11

Merged
merged 4 commits into from
Nov 24, 2023

Conversation

theforager
Copy link
Contributor

This just enables compilation with later compiler versions. As of Noir compiler v0.19.0, it will validate the compiler_version is compatible, and it requires >= to compiler with later versions.

NOTE: This requires the pull request on the noir-array-helpers to be merged to actually compile with >=0.19.0. However, just merging this PR shouldn't break anything.

colinnielsen/noir-array-helpers#8

@colinnielsen
Copy link
Owner

thank you for the pr @theforager ! I'd actually prefer to bump the version in the Nargo.toml to >=0.19.0, then i can do a 0.19.0 GitHub release here. it's been convenient to sync the noir versions when using the package as a dependency

@theforager
Copy link
Contributor Author

Sounds good! Do you want to setup the 0.19.0 release for noir-array-helpers, and then I can update that in the dependencies here?

@colinnielsen
Copy link
Owner

Sounds good! Do you want to setup the 0.19.0 release for noir-array-helpers, and then I can update that in the dependencies here?

that'd be great. i just released the helpers @v0.19.0 so you can use that as the dep. also if you could bump the version in CI, that'd be appreciated

@theforager
Copy link
Contributor Author

@colinnielsen Should be good to go! LMK if we need anything else.

@colinnielsen colinnielsen merged commit 6d5cee2 into colinnielsen:main Nov 24, 2023
1 check passed
@colinnielsen
Copy link
Owner

@theforager merged and released. thanks mate!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants