Using API params only #697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mattwire - thank you for the call this morning! I've cleaned this up and have also adjusted the matrix so that we're now running D9.3.4 against 4 different CiviCRM versions. Will merge on pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
We ran into an issue where one of the iATS tests had started failing due to a change in propertybag in CiviCRM Core
Add billingStateProvince and standardized property names by mattwire · Pull Request #21583 · civicrm/civicrm-core
Before
Contains propertyBag references
After
propertyBag references are removed - using API params only.
Technical Details
Note: All payment processor tests including -> Stripe FunctionalJavascript test pass ✅
I've only commented out //// the propertyBag bits for now to clearly show what can be removed.