d8 port of #180- Use the payment processor payment method instead of the default c… #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jitendrapurohit
changed the title
jitendrapurohit
commented
Feb 9, 2021
| @@ -2148,6 +2141,9 @@ private function contributionParams() { | |||
| 'domain_id' => $domain, | |||
| )); | |||
| } | |||
| if (empty($params['payment_instrument_id']) && !empty($params['payment_processor_id'])) { | |||
There was a problem hiding this comment.
@jitendrapurohit - can you please add a few lines to the ContributionIatsTest -> section line 180-186 to check that with this PR the payment_instrument_id is indeed no longer check (default) but credit card?
There was a problem hiding this comment.
Done. Thanks for the pointer 👍 @KarinG
There was a problem hiding this comment.
Awesome - it's just a few lines but nice to secure this 👍
|
Squashing and merging ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…onfigured one
Overview
d8 port for #180
Before
Default payment instrument is set for the contribution.
After
Payment processor instrument is set for the contirbution done via webforms.