Skip to content
This repository has been archived by the owner on Dec 7, 2021. It is now read-only.

Use data uri scheme for favicon urls #28

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use data uri scheme for favicon urls #28

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/Tab.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ function Tab({ tab, isHighlighted, onRemove, ...props }) {
return (
<Container isHighlighted={isHighlighted} {...props}>
<FavIcon>
{/^https?:\/\//.test(tab.favIconUrl) ? (
{/^(https?:\/\/|data:image)/.test(tab.favIconUrl) ? (
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@colebemis this fixes src=data:image favicons from "Great Suspender"

<img src={tab.favIconUrl} alt="" width="100%" height="100%" />
) : (
favIconPlaceholder
Expand Down