Skip to content

Commit

Permalink
re-enable broken tests
Browse files Browse the repository at this point in the history
  • Loading branch information
colearendt committed May 31, 2020
1 parent 0a23b85 commit 129576b
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 7 deletions.
5 changes: 0 additions & 5 deletions tests/testthat/test-gather_object.R
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ context("gather_object")

test_that("works in a simple case", {

skip("wait: testthat")
json <- '{"name1": 1, "name2": 2}'

expect_identical(
Expand All @@ -21,7 +20,6 @@ test_that("works in a simple case", {
)

test_that("works with compound values", {
skip("wait: testthat")

json <- '{
"name1": 1,
Expand Down Expand Up @@ -79,7 +77,6 @@ test_that("correctly handles character(0), {}, []", {

test_that("column.name doesn't clobber existing name", {

skip("wait: testthat")
expect_identical(
'{"name1": 1, "name2": 2}' %>%
as.tbl_json %>%
Expand All @@ -99,7 +96,6 @@ test_that("column.name doesn't clobber existing name", {
)

test_that("preserves a NULL column", {
skip("wait: testthat")

expect_identical(
'{"name1": 1, "name2": 2}' %>%
Expand Down Expand Up @@ -150,7 +146,6 @@ test_that("gather_keys has right column name", {
})

test_that("can call repeatedly without having to change column.name", {
skip("wait: testthat")
expect_identical(
suppressWarnings('{"n1": {"n2": 1}}' %>% gather_object %>% gather_object),
tbl_json(
Expand Down
2 changes: 0 additions & 2 deletions tests/testthat/test-json_structure.R
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ test_that("simple string works", {
})

test_that("simple object works", {
skip("wait: testthat")
actual <- '{"name": "value"}' %>% json_structure
expected <- tbl_json(
dplyr::tibble(
Expand Down Expand Up @@ -73,7 +72,6 @@ test_that("simple array works", {

test_that("nested object works", {

skip("wait: testthat")
expect_identical(
'{"k1": {"k2": "value"}}' %>% json_structure,
tbl_json(
Expand Down

0 comments on commit 129576b

Please sign in to comment.