Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ValidationManager errors when returning validatedKeys due to sharedconstraint name #71

Closed
gpickin opened this issue Apr 12, 2023 · 2 comments

Comments

@gpickin
Copy link
Contributor

gpickin commented Apr 12, 2023

https://github.com/coldbox-modules/cbvalidation/blob/development/models/ValidationManager.cfc#L283

If you pass in a shared constraint name to validateOrFail(target=rc, constraints="loginForm");
The validate function handles the shared constraint name... and validates correctly.

On 283, it uses constraints.keyExists( key ) but key in still the shared constraint name "loginForm" - it hasn't been exploded into the full struct of Constraints.

This needs to be resolved.

Found by PowerToaster in the ortus community forum.
https://community.ortussolutions.com/t/the-function-keyexists-does-not-exist-in-the-string/9601

@bdw429s
Copy link
Contributor

bdw429s commented Apr 12, 2023

This issue has been mentioned on Ortus Solutions Community. There might be relevant details there:

https://community.ortussolutions.com/t/the-function-keyexists-does-not-exist-in-the-string/9601/2

lmajano added a commit that referenced this issue Apr 13, 2023
@lmajano
Copy link
Contributor

lmajano commented Apr 13, 2023

#71
closed

@lmajano lmajano closed this as completed Apr 13, 2023
@lmajano lmajano mentioned this issue Apr 14, 2023
lmajano added a commit that referenced this issue Apr 14, 2023
### Added

- New github action versions and consolidation of actions
- New [Contributing](CONTRIBUTING.md) guidelines
- New github support templates

### Changed

- The way custom validators are retrieved so they are ColdBox 7+ compatible
- `pr` github action now just does format checks to avoid issues with other repos.
- Consolidated Adobe 2021 scripts into the server scripts

### Fixed

- Fix for `tasks.json` file to include no recursion
- #71 - ValidationManager errors when returning `validatedKeys` due to `sharedconstraint` name
- #45 - `Type` validator needs to be able to validate against `any` type even if that is an empty string
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants