Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for command invocation with a 'default verb' #656

Merged
merged 5 commits into from
Jul 25, 2024

Conversation

cottsay
Copy link
Member

@cottsay cottsay commented Jul 24, 2024

There are no plans to use this feature to allow the 'colcon' executable to be invoked without a verb, but other tools built on colcon-core's framework may not want multiple verbs.

There are no plans to use this feature to allow the 'colcon' executable
to be invoked without a verb, but other tools built on colcon-core's
framework may not want multiple verbs.
@cottsay cottsay added the enhancement New feature or request label Jul 24, 2024
@cottsay cottsay requested a review from nuclearsandwich July 24, 2024 18:29
@cottsay cottsay self-assigned this Jul 24, 2024
Copy link

codecov bot commented Jul 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.34%. Comparing base (5c56e00) to head (69c5ee0).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #656      +/-   ##
==========================================
+ Coverage   87.27%   87.34%   +0.07%     
==========================================
  Files          67       67              
  Lines        3906     3913       +7     
  Branches      774      776       +2     
==========================================
+ Hits         3409     3418       +9     
  Misses        391      391              
+ Partials      106      104       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@nuclearsandwich nuclearsandwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-review for the class instance -> class type changes.

colcon_core/command.py Outdated Show resolved Hide resolved
@cottsay cottsay added this to the 0.17.1 milestone Jul 25, 2024
@cottsay cottsay merged commit 633ae37 into master Jul 25, 2024
36 checks passed
@cottsay cottsay deleted the cottsay/default-verb branch July 25, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

2 participants