Consider alternate pytest_cov version string format

[christophebedard]

Fixes #433

Try to check with the "new" version string pattern to see if there is a match. If there is one, use that as the x.y.z version.

Signed-off-by: Christophe Bedard [email protected]

[christophebedard]

This works for me. I'm wondering if this is going to be considered a bug (pytest-dev/pytest-cov#468). In any case, this fix is needed for pytest_cov=={2.10.1,2.11.0,2.11.1}.

[codecov]

Codecov Report

Merging #434 (08286df) into master (e775de7) will decrease coverage by 0.11%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #434      +/-   ##
==========================================
- Coverage   79.45%   79.33%   -0.12%     
==========================================
  Files          57       57              
  Lines        3368     3373       +5     
  Branches      565      566       +1     
==========================================
  Hits         2676     2676              
- Misses        644      649       +5     
  Partials       48       48              

Impacted Files	Coverage Δ
colcon_core/task/python/test/pytest.py	0.00% <0.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e775de7...08286df. Read the comment docs.

[christophebedard]

This works for me. I'm wondering if this is going to be considered a bug (pytest-dev/pytest-cov#468). In any case, this fix is needed for pytest_cov=={2.10.1,2.11.0,2.11.1}.

It was considered a bug and fixed: pytest-dev/pytest-cov@f5a4d7e. So it should be fine for >2.11.1, but for 2.10.1 to 2.11.1 we need this PR.

[dirk-thomas]

Since a new version of pytest-cov was released I don't see a case where anyone would install a version from the range where it was broken. Do you agree that this can be closed?

[christophebedard]

Since a new version of pytest-cov was released I don't see a case where anyone would install a version from the range where it was broken. Do you agree that this can be closed?

Yeah sure, that's fine.

[dirk-thomas]

Thanks for your effort to get this resolved upstream!