Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: catch file stream error #31

Merged
merged 6 commits into from
May 6, 2023
Merged

fix: catch file stream error #31

merged 6 commits into from
May 6, 2023

Conversation

haoxins
Copy link
Member

@haoxins haoxins commented Jan 6, 2016

No description provided.

@haoxins haoxins mentioned this pull request Jan 6, 2016
@haoxins
Copy link
Member Author

haoxins commented Jan 6, 2016

cc @fengmk2

@codecov-io
Copy link

codecov-io commented Jan 6, 2016

Current coverage is 100% (diff: 100%)

No coverage report found for master at 750e8d2.

Powered by Codecov. Last update 750e8d2...624ad34

@haoxins
Copy link
Member Author

haoxins commented Jan 7, 2016

#28
#29

@imyelo
Copy link

imyelo commented Jul 30, 2016

any progress on this?

@haoxins
Copy link
Member Author

haoxins commented Aug 4, 2016

@fengmk2 any advice?

index.js Outdated
@@ -27,7 +27,7 @@ module.exports = function (request, options) {
.on('field', onField)
.on('file', onFile)
.on('close', cleanup)
.on('error', onEnd)
.on('error', onError)
.on('finish', onEnd)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

finish event will be emit aftererror event?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea

@fengmk2 fengmk2 force-pushed the fix-stream-error branch from 9c3dc11 to 5f9425a Compare May 6, 2023 16:07
@fengmk2 fengmk2 marked this pull request as draft May 6, 2023 16:21
@fengmk2 fengmk2 marked this pull request as ready for review May 6, 2023 16:29
@fengmk2 fengmk2 merged commit 448fc4b into master May 6, 2023
@fengmk2 fengmk2 deleted the fix-stream-error branch May 6, 2023 16:41
@fengmk2
Copy link
Member

fengmk2 commented May 6, 2023

2.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants