Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parse yarn audit text output into json #181

Merged
merged 9 commits into from
Sep 4, 2020
Merged

parse yarn audit text output into json #181

merged 9 commits into from
Sep 4, 2020

Conversation

ghbren
Copy link
Contributor

@ghbren ghbren commented Sep 3, 2020

No description provided.

Copy link
Contributor

@cbtoni cbtoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments, I'm also going to run this on some test repos too

lib/salus/scanners/yarn_audit.rb Outdated Show resolved Hide resolved
lib/salus/scanners/yarn_audit.rb Outdated Show resolved Hide resolved
lib/salus/scanners/yarn_audit.rb Outdated Show resolved Hide resolved
# We must also pluck out only the standard advisory hashes.
command = "#{AUDIT_COMMAND} #{scan_deps}"
command_output = run_shell(command)
# severity and vuln title in the yarn output looks like
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice comment!

Copy link
Contributor

@cbtoni cbtoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work for me locally!

@ghbren ghbren merged commit ec459fc into master Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants