Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: appchain bridge UI #1976

Merged
merged 22 commits into from
Feb 13, 2025
Merged

feat: appchain bridge UI #1976

merged 22 commits into from
Feb 13, 2025

Conversation

0xAlec
Copy link
Contributor

@0xAlec 0xAlec commented Feb 12, 2025

What changed? Why?
add FE components for bridge UI

will rebase and change reference to master once #1971 is merged

Notes to reviewers

How has it been tested?
unit tests, QA, playground

@0xAlec 0xAlec changed the base branch from main to alec/bridge-hooks- February 12, 2025 17:15
Copy link

vercel bot commented Feb 12, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
onchainkit-coverage ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 13, 2025 3:26pm
onchainkit-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 13, 2025 3:26pm
onchainkit-routes ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 13, 2025 3:26pm

@0xAlec 0xAlec changed the title Alec/bridge components feat: appchain bridge UI Feb 12, 2025
@0xAlec 0xAlec force-pushed the alec/bridge-components branch from 72ece71 to 823aa42 Compare February 12, 2025 18:09
@0xAlec 0xAlec force-pushed the alec/bridge-components branch from 95f2de9 to ae2a7f1 Compare February 12, 2025 18:14
@0xAlec 0xAlec force-pushed the alec/bridge-components branch from ae2a7f1 to 6061cbb Compare February 12, 2025 18:30
@0xAlec 0xAlec marked this pull request as ready for review February 12, 2025 18:35
@0xAlec 0xAlec changed the base branch from alec/bridge-hooks- to main February 12, 2025 18:39
background.default,
border.radius,
color.foreground,
'flex w-[500px] flex-col px-6 pt-6 pb-4 border ock-border-line-default',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

w-full/max-w-[500px] may be a better solution here, allowing the component to scale

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, thanks

@0xAlec 0xAlec merged commit 08e073c into main Feb 13, 2025
16 checks passed
@0xAlec 0xAlec deleted the alec/bridge-components branch February 13, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants