-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: send utils #1875
Merged
Merged
feat: send utils #1875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
brendan-defi
force-pushed
the
feat/send-utils
branch
from
January 24, 2025 17:14
862de43
to
aa3563a
Compare
cpcramer
reviewed
Jan 24, 2025
cpcramer
reviewed
Jan 24, 2025
dschlabach
previously approved these changes
Jan 24, 2025
brendan-defi
force-pushed
the
feat/send-utils
branch
from
January 24, 2025 19:07
91c7ead
to
6113a71
Compare
dschlabach
approved these changes
Jan 24, 2025
abcrane123
approved these changes
Jan 24, 2025
cpcramer
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Added / updated utilities and hooks to be used by
Send
component, including:getAddress
— added chain check and fixed issue with basename resolvergetName
— minor refactor for hygieneisEns
— basic test to see if an input could be an ENS nametruncateDecimalPlaces
— rounds and truncates numbers / stringsgetValidatedAddress
— returns a valid EVM address from a basename, ens, or address inputuseExchangeRate
— usesgetSwapQuote
to get an exchange rate for a token against USDC, handles state updatesuseAmountInput
— refactored from FundCard, handles crypto/fiat value input changesNotes to reviewers
How has it been tested?