Access PublicKeys During Construction #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrick-ogrady
changed the title
juliankoh
approved these changes
Sep 1, 2020
juliankoh
approved these changes
Sep 1, 2020
This was referenced Oct 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #43
Additional Context: https://community.rosetta-api.org/t/any-way-to-get-public-key-from-signer-package-before-combine/189
Motivation
In some blockchains, transaction construction requires the
PublicKeyof someAccountIdentifierspresent in a transaction.Changes
This PR allows a Rosetta implementation to request the
PublicKeyof any number ofAccountIdentifiersin the/construction/preprocessresponse. The caller can then provide the requestedPublicKeysin a call to/construction/payloadsso that construction can be completed.