Add Coin Model #30
Merged
Add Coin Model #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrick-ogrady
force-pushed
the
patrick/sync-status
branch
from
997d29b to
0fee82f
Compare
juliankoh
approved these changes
Jul 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support automatic testing of UTXO-based chains, we need greater visibility into the creation and destruction of "coins". This PR adds support for doing so with the concept of the
Coin. Generic UTXOs in Rosetta have acoin_identifier, which can be any string (ex: Bitcoin would betx_hash:index), and can be created or spent withCoinAction.Because of this modeling abstraction, it is possible to support both UTXO-based transfers and account-based transfers at the same time.
Related Issue: #28
Changes
Coin,CoinIdentifier,CoinChange, andCoinActionmodelCoinChangeas an optional field onOperationcoinsas an optional field inAccountBalanceResponse