TransactionIdentifierResponse + change default status to 500 #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrick-ogrady
force-pushed
the
patrick/unify-tx-identifier
branch
from
b84d6f4 to
439cfa9
Compare
patrick-ogrady
changed the title
patrick-ogrady
changed the title
patrick-ogrady
changed the title
yfl92
approved these changes
Jul 25, 2020
|
Review Error for slowboat0 @ 2020-07-25 17:07:40 UTC |
qiwu7
approved these changes
Jul 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #28
Changes
TransactionIdentifierResponsefor both/construction/hashand/construction/submit[BREAKING for/construction/hashbecause of a mistake in v1.4.0]500as response status instead ofdefault(this is already specified in the docs: https://www.rosetta-api.org/docs/BlockApi.html#500---error-1)