Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add historical_balance_lookup to NetworkOptionsResponse #19

Closed
patrick-ogrady opened this issue Jun 24, 2020 · 0 comments · Fixed by #22
Closed

Add historical_balance_lookup to NetworkOptionsResponse #19

patrick-ogrady opened this issue Jun 24, 2020 · 0 comments · Fixed by #22
Labels
enhancement New feature or request

Comments

@patrick-ogrady
Copy link
Contributor

Is your feature request related to a problem? Please describe.
When running rosetta-cli check, the only argument that developers ever provide (to override the default) is --lookup-balance-by-block=false. This argument has caused a lot of confusion and the specification should be modified so that this can be inferred automatically from an implementation.

Describe the solution you'd like
Add something like historical_balance_lookup to NetworkOptionsResponse so that we can remove this setting entirely from rosetta-cli.
https://github.com/coinbase/rosetta-specifications/blob/439b881859b0982bb6baf34a9666db1018d419f9/api.yaml#L615-L627

Describe alternatives you've considered
We already provide a lot of documentation around this flag but it is often overlooked during implementation as there are so many other factors on developers' minds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging a pull request may close this issue.

1 participant