chore: add unit tests to headerforwarder package #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Heimdall Review Status
|
potterbm-cb
commented
Nov 27, 2024
| @@ -132,7 +132,14 @@ func (hf *HeaderForwarder) rememberHeaders(req *http.Request, resp *http.Respons | |||
|
|
|||
| // Only remember interesting headers | |||
| for _, interestingHeader := range hf.interestingHeaders { | |||
| headersToRemember.Set(interestingHeader, resp.Header.Get(interestingHeader)) | |||
There was a problem hiding this comment.
this line was overwriting each header value, not adding
GeekArthur
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This utility was part of a proof-of-concept and this is an attempt to move it closer to a production-ready state
Solution
HeaderForwarderandheaderforwarder.ResponseWriterwere not tested, lacking specific code/documentation about edge casesThis PR adds those tests and fixes some issues uncovered by the testing