Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable target account checking #409

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Conversation

jingweicb
Copy link
Contributor

@jingweicb jingweicb commented Nov 22, 2023

Enable interested account checking feature,
added target account as a flag
tested in following picture

Screenshot 2023-12-08 at 9 51 03 AM

Motivation

Solution

Open questions

@jingweicb jingweicb force-pushed the enable-target-acc-checking branch from 1351301 to 8076855 Compare December 8, 2023 18:26
@jingweicb jingweicb requested a review from shiatcb December 8, 2023 18:33
shiatcb
shiatcb previously approved these changes Dec 8, 2023
@jingweicb jingweicb marked this pull request as ready for review December 8, 2023 18:48
@jingweicb jingweicb marked this pull request as draft December 8, 2023 18:53
@cb-heimdall cb-heimdall dismissed shiatcb’s stale review December 8, 2023 20:23

Approved review 1772956960 from shiatcb is now dismissed due to new commit. Re-request for approval.

@jingweicb jingweicb force-pushed the enable-target-acc-checking branch from 51109e7 to 6a45bc1 Compare December 8, 2023 20:26
@jingweicb jingweicb marked this pull request as ready for review December 8, 2023 20:32
@jingweicb jingweicb merged commit ae92cd6 into master Dec 8, 2023
8 checks passed
@jingweicb jingweicb deleted the enable-target-acc-checking branch December 8, 2023 20:32
@jingweicb jingweicb changed the title enable target acc checking Enable target account checking Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants