Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable requestUUID #376

Merged
merged 5 commits into from
Dec 8, 2022
Merged

enable requestUUID #376

merged 5 commits into from
Dec 8, 2022

Conversation

jingweicb
Copy link
Contributor

Fixes # .
use two methods to add requestUUID
1, add it into ctx
2, add it to logger

Screenshot 2022-12-08 at 12 17 56 AM

Screenshot 2022-12-08 at 12 19 26 AM

Motivation

Solution

Open questions

xiaying-peng
xiaying-peng previously approved these changes Dec 8, 2022
pkg/logger/logger.go Outdated Show resolved Hide resolved
@xiaying-peng xiaying-peng self-requested a review December 8, 2022 22:24
@cb-heimdall cb-heimdall dismissed xiaying-peng’s stale review December 8, 2022 22:24

Approved review 1210852456 from xiaying-peng is now dismissed due to new commit. Re-request for approval.

@xiaying-peng xiaying-peng merged commit a05b3ef into master Dec 8, 2022
@xiaying-peng xiaying-peng deleted the jingwei/requestID branch December 8, 2022 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants