Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in types.go #253

Merged
merged 3 commits into from
Nov 22, 2021
Merged

Fix typos in types.go #253

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5da2d00
Fix typos in types.go
racbc Nov 11, 2021
f6a6ea6
Fix misspelling of "discrepancy" in coinbase/rosetta-cli files
racbc Nov 16, 2021
b38157e
Add json generated file
racbc Nov 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions configuration/types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,11 +278,11 @@ type DataConfiguration struct {
// been drained (if reconciliation is enabled).
ReconciliationDrainDisabled bool `json:"reconciliation_drain_disabled"`

// InactiveDiscrepencySearchDisabled is a boolean indicating if a search
// should be performed to find any inactive reconciliation discrepencies.
// InactiveDiscrepancySearchDisabled is a boolean indicating if a search
// should be performed to find any inactive reconciliation discrepancies.
// Note, a search will never be performed if historical balance lookup
// is disabled.
InactiveDiscrepencySearchDisabled bool `json:"inactive_discrepency_search_disabled"`
InactiveDiscrepancySearchDisabled bool `json:"inactive_discrepancy_search_disabled"`

// BalanceTrackingDisabled is a boolean that indicates balances calculation
// should not be attempted. When first testing an implemenation, it can be
Expand All @@ -301,7 +301,7 @@ type DataConfiguration struct {
// If no blocks have ever been synced, syncing will start from genesis.
StartIndex *int64 `json:"start_index,omitempty"`

// EndCondition contains the conditions for the syncer to stop
// EndCondition contains the conditions for the syncer to stop.
EndConditions *DataEndConditions `json:"end_conditions,omitempty"`

// StatusPort allows the caller to query a running check:data
Expand Down
2 changes: 1 addition & 1 deletion examples/configuration/default.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
"interesting_accounts": "",
"reconciliation_disabled": false,
"reconciliation_drain_disabled": false,
"inactive_discrepency_search_disabled": false,
"inactive_discrepancy_search_disabled": false,
"balance_tracking_disabled": false,
"coin_tracking_disabled": false,
"status_port": 9090,
Expand Down
2 changes: 1 addition & 1 deletion examples/configuration/simple.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"data": {
"historical_balance_enabled": false,
"reconciliation_disabled": true,
"inactive_discrepency_search_disabled": true,
"inactive_discrepancy_search_disabled": true,
"balance_tracking_disabled": true,
"end_conditions": {
"tip": true
Expand Down
4 changes: 2 additions & 2 deletions pkg/tester/data.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -931,8 +931,8 @@ func (t *DataTester) HandleErr(err error, sigListeners *[]context.CancelFunc) er
)
}

if t.config.Data.InactiveDiscrepencySearchDisabled {
color.Yellow("Search for inactive reconciliation discrepency is disabled")
if t.config.Data.InactiveDiscrepancySearchDisabled {
color.Yellow("Search for inactive reconciliation discrepancy is disabled")
return results.ExitData(
t.config,
t.counterStorage,
Expand Down