Make exempt accounts file configuration relative to main config file #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yfl92
reviewed
Mar 16, 2021
| @@ -334,6 +334,10 @@ func modifyFilePaths(config *Configuration, fileDir string) { | |||
| if len(config.Data.InterestingAccounts) > 0 { | |||
| config.Data.InterestingAccounts = path.Join(fileDir, config.Data.InterestingAccounts) | |||
| } | |||
|
|
|||
| if len(config.Data.ExemptAccounts) > 0 { | |||
| config.Data.ExemptAccounts = path.Join(fileDir, config.Data.ExemptAccounts) | |||
yfl92
reviewed
Mar 16, 2021
configuration/types.go
Outdated
Comment on lines
354
to
355
| // The path can be absolute or relative to the directory containing the rosetta-cli | ||
| // binary. |
There was a problem hiding this comment.
Feels like this comment could be a bit misleading. The DataDirectory is either absolute or relative to where the binary is being executed instead of the path to the binary
Pull Request Test Coverage Report for Build 6916
💛 - Coveralls |
yfl92
approved these changes
Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # #215
Motivation
The documentation for exempt_accounts configuration, states that it should specify a path to a file relative to the configuration file. But, the code was actually looking for files relative to the rosetta-cli binary.
Solution
Updated behavior to match the documentation i.e. the exempt accounts file is looked up relative to the main configuration file.
Open questions