feat: use factory to create blob storage according to config #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
linked to #45 |
bestmike007
force-pushed
the
feat/configurable-blob-storage
branch
from
3d62c23 to
d7d3125
Compare
jiezhang
reviewed
Oct 18, 2023
jiezhang
reviewed
Oct 19, 2023
internal/storage/blobstorage/s3/blob_storage_integration_test.go
Outdated
Show resolved
Hide resolved
leozc
previously approved these changes
Oct 19, 2023
|
Review Error for leozc @ 2023-10-19 03:45:57 UTC |
Signed-off-by: bestmike007 <[email protected]>
Signed-off-by: bestmike007 <[email protected]>
Signed-off-by: bestmike007 <[email protected]>
Signed-off-by: bestmike007 <[email protected]>
Signed-off-by: bestmike007 <[email protected]>
Signed-off-by: bestmike007 <[email protected]>
Signed-off-by: bestmike007 <[email protected]>
bestmike007
force-pushed
the
feat/configurable-blob-storage
branch
from
0914f19 to
07c4869
Compare
jiezhang
reviewed
Oct 20, 2023
Signed-off-by: bestmike007 <[email protected]>
jiezhang
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Ticket - #45
Make blob storage type configuration, in order to support other platforms like GCP, Azure, local filesystem, etc.
TODO:
BlobStorageTypeHow did you test the change?
make config,make test,make integration, andmake server