Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for deploying arbitrary contracts #86

Merged
merged 6 commits into from
Jan 17, 2025

Conversation

rohan-agarwal-coinbase
Copy link
Contributor

What changed? Why?

  • Added deploy_contract in wallet_address.py and wallet.py to support deploying an arbitrary contract using the compiler version, solidity input json, contract name of the class to be deployed, and constructor arguments

Testing

  • Unit tests added
  • E2E test succeeds

Qualified Impact

0xRAG
0xRAG previously approved these changes Jan 17, 2025
Copy link
Contributor

@0xRAG 0xRAG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

CHANGELOG.md Outdated Show resolved Hide resolved
@cb-heimdall
Copy link

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@rohan-agarwal-coinbase
Copy link
Contributor Author

Merging despite e2e tests failing since they look unrelated and flaky

@rohan-agarwal-coinbase rohan-agarwal-coinbase merged commit 5ebda7f into v0.15.0 Jan 17, 2025
7 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants