chore(PSDK-640): add network_id to WalletData #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CHANGELOG.md
Outdated
| @@ -7,6 +7,7 @@ | |||
| ### Added | |||
|
|
|||
| - Wallet address contract invocation input validation for payable contracts. | |||
| - Add `network_id` to `WalletData` so that it is saved with the seed data and surfaced via the export function | |||
There was a problem hiding this comment.
Please add new changes under Unreleased heading until the new release is being cut
0xRAG
changed the title
cdp/wallet_data.py
Outdated
| @@ -32,14 +34,27 @@ def seed(self) -> str: | |||
| """ | |||
| return self._seed | |||
|
|
|||
| @property | |||
| def network_id(self) -> str: | |||
There was a problem hiding this comment.
Return type can be None -> str | None
John-peterson-coinbase
approved these changes
Dec 18, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
It should be clear which saved wallets belong to which networks when you
save_seed/export_datafor a given wallet.How i tested
After running:
wallet_seed.jsonlooks like:{ "11cd62ab-0046-472d-bb16-3ad560bdf2d4": { "seed": "21exxx", "encrypted": false, "auth_tag": "", "iv": "", "network_id": "base-mainnet" } }And the result of
wallet.export():Qualified Impact
The network id should always be present, and if it is not, it will simply not be included in the WalletData